Skip to content

Updates to resources and yaml files from GFS C1152 cycled testing#3634

Merged
KateFriedman-NOAA merged 261 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:retrotest2develop
May 19, 2025
Merged

Updates to resources and yaml files from GFS C1152 cycled testing#3634
KateFriedman-NOAA merged 261 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:retrotest2develop

Conversation

@JessicaMeixner-NOAA

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented May 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds yaml files that are being used for GFSv17 C1152 cycled testing.
It updates resources that have been used to get C1152 cycled tests running on wcoss2 and on Gaea (Note for Gaea an additional change to config.ufs is needed to increase the number of tasks on the write grid component. It's my understanding that because of calculations done other places we can't put an "if gaea" there and it has to be manually changed, so a note is added).

Resolves #3227

Type of change

  • Bug fix (fixes something broken) - These are fixes for C1152 cycling
  • Adds Feature : Stores yamls being used for C1152 cycling

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

These have been used in C1152 testing on WCOSS2, Gaea and MSU.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

JessicaMeixner-NOAA and others added 30 commits January 30, 2025 21:30
@JessicaMeixner-NOAA
remove loop in JGLOBAL_WAVE_POST_SBS
ee352fe
@JessicaMeixner-NOAA
Merge branch 'NOAA-EMC:develop' into fixhighrestest
583e2fb
@JessicaMeixner-NOAA
update ufs weather model hash
300f8f0
@JessicaMeixner-NOAA
updating script for shell check
02210bf
@JessicaMeixner-NOAA
add fv3 output variable to model_configure
bbd9bd8
@JessicaMeixner-NOAA
Merge branch 'NOAA-EMC:develop' into fixhighrestest
df709ba
@JessicaMeixner-NOAA
point to ww3 with point updates
5bb8f70
adding .nc to ush/forecast_postdet.sh in the point output name for ne…
f65f51e 
…tcdf output
@JessicaMeixner-NOAA
update ww3
48091ee
@JessicaMeixner-NOAA
update ww3
682b4c2
@AliS-Noaa
modified the exgfs_wave_post_pnt.sh; config.resources; wave_tar.sh to…
58102cd 
… be compatible with the optimized ww3_outp fot netcdf point outputs, per_time_step
@AliS-Noaa
Merge branch 'pointopt' of github.com:AliS-Noaa/global-workflow into …
5bb31c3 
…pointopt
@AliS-Noaa
modified the raw point output name for the netcdf file
6af9b87
@AliS-Noaa
modified exgfs_wave_post_pnt.sh; ww3_outp.in; wave_tar.sh to be compa…
62aebc6 
…tible with the new optimized ww3_outp program with the netcdf inputs
@AliS-Noaa
changing the wave_tar.sh and template ww3_outp to work with the retri…
58a8c3e 
…eved prefix
@AliS-Noaa
using DTPNT_WAV for time step in the wave_pnt script
ce18247
@AliS-Noaa
Merge remote-tracking branch 'origin/pointopt' into optoutp
7eba140
@AliS-Noaa
pointing to AliS ufs_model and WW3
735dbd7
@AliS-Noaa
Merge branch 'NOAA-EMC:develop' into optoutp
ffdf632
@CatherineThomas-NOAA
Point to JessicaMeixner-NOAA:cycling ufs-weather-model branch for wav…
ba6975d 
…es cycling
@CatherineThomas-NOAA
Update sfcanl jobs to use ufsda modules
6270c9f
@CatherineThomas-NOAA
Changes for aerosol data and walltime
5bc9d6f
@CatherineThomas-NOAA
aeroanlgenb fix
6154ad0
@CatherineThomas-NOAA
Update marine DA resources
c667e81
@CatherineThomas-NOAA
Update marine DA walltime
b3a9fe3
@CatherineThomas-NOAA
Point to temp soil DA fix files
bb83a64
@CatherineThomas-NOAA
Update gitmodules for ufs_model.fd
6e2ff0d
@CatherineThomas-NOAA
Bugfixes for wave init and ocean archiving
5c5c998
@CatherineThomas-NOAA
Remove -l from WCOSS2.env launcher for cleaner output
91f680d
@CatherineThomas-NOAA
Fix for archiving ocean bmatrix files
430799e
@aerorahul aerorahul added CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. labels May 16, 2025
KateFriedman-NOAA
KateFriedman-NOAA previously approved these changes May 16, 2025
View reviewed changes

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @JessicaMeixner-NOAA !

@emcbot emcbot added CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 CI-Gaeac6-Running CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress and removed CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels May 16, 2025
@emcbot

emcbot commented May 16, 2025

Copy link
Copy Markdown

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3634/RUNTESTS on WCOSS

@emcbot

emcbot commented May 16, 2025

Copy link
Copy Markdown

Experiment C96C48mx500_S2SW_cyc_gfs FAILED on Gaeac6 in Build# 1 with error logs:

/gpfs/f6/drsa-precip3/world-shared/global/CI/3634/RUNTESTS/COMROOT/C96C48mx500_S2SW_cyc_gfs_cd280892/logs/2021122018/enkfgfs_earc_tars_00.log

Follow link here to view the contents of the above file(s): (enkfgfs_earc_tars_00.log)

@emcbot emcbot added CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed and removed CI-Gaeac6-Running labels May 16, 2025
@emcbot

emcbot commented May 16, 2025

Copy link
Copy Markdown

Experiment C96C48mx500_S2SW_cyc_gfs FAILED on Gaeac6 in Build# 1 in
/gpfs/f6/drsa-precip3/world-shared/global/CI/3634/RUNTESTS/EXPDIR/C96C48mx500_S2SW_cyc_gfs_cd280892

@emcbot emcbot added CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed and removed CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed labels May 16, 2025
@KateFriedman-NOAA

KateFriedman-NOAA commented May 19, 2025

Copy link
Copy Markdown
Contributor

CI testing completed successfully on WCOSS2:

Mon May 19 13:48:26 UTC 2025
******** C48_ATM_3634 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    May 16 2025 19:59:36    May 16 2025 20:55:39

******** C48mx500_3DVarAOWCDA_3634 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    May 16 2025 19:59:41    May 16 2025 20:15:46
202103250000        Done    May 16 2025 19:59:41    May 16 2025 21:35:43

******** C48mx500_hybAOWCDA_3634 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    May 16 2025 19:59:54    May 16 2025 20:15:52
202103250000        Done    May 16 2025 19:59:54    May 16 2025 21:20:41

******** C48_S2SW_3634 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    May 16 2025 20:00:03    May 16 2025 20:56:18

******** C48_S2SWA_gefs_3634 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    May 16 2025 20:00:13    May 16 2025 21:06:19

******** C96_atm3DVar_extended_3634 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    May 16 2025 20:00:20    May 16 2025 20:16:19
202112210000        Done    May 16 2025 20:00:20    May 17 2025 00:25:45
202112210600        Done    May 16 2025 20:00:20    May 17 2025 01:15:55
202112211200        Done    May 16 2025 20:21:10    May 17 2025 02:05:48
202112211800        Done    May 17 2025 00:30:55    May 17 2025 05:21:03

******** C96C48_hybatmaerosnowDA_3634 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    May 16 2025 20:00:24    May 16 2025 20:21:17
202112201800        Done    May 16 2025 20:00:24    May 16 2025 22:26:04
202112210000        Done    May 16 2025 20:00:24    May 16 2025 22:20:57

******** C96C48_hybatmDA_3634 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    May 16 2025 20:00:33    May 16 2025 20:16:31
202112210000        Done    May 16 2025 20:00:33    May 16 2025 22:21:01
202112210600        Done    May 16 2025 20:00:33    May 16 2025 22:11:05

******** C96C48mx500_S2SW_cyc_gfs_3634 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    May 16 2025 20:00:38    May 16 2025 20:16:37
202112201800        Done    May 16 2025 20:00:38    May 16 2025 22:26:11
202112210000        Done    May 16 2025 20:00:38    May 16 2025 23:20:56
202112211800        Done    May 16 2025 20:21:28    May 16 2025 23:16:06

******** C96C48_ufs_hybatmDA_3634 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202402231800        Done    May 16 2025 20:00:45    May 16 2025 20:16:43
202402240000        Done    May 16 2025 20:00:45    May 16 2025 22:55:58
202402240600        Done    May 16 2025 20:00:45    May 16 2025 22:36:21

******** C96mx100_S2S_3634 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
199405010000        Done    May 16 2025 20:00:50    May 16 2025 21:32:01

@KateFriedman-NOAA KateFriedman-NOAA added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels May 19, 2025
DavidHuber-NOAA
DavidHuber-NOAA reviewed May 19, 2025
View reviewed changes
Comment thread dev/parm/config/gfs/config.resources Outdated
@JessicaMeixner-NOAA @DavidHuber-NOAA
Update dev/parm/config/gfs/config.resources
f7c31bd 
Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com>
DavidHuber-NOAA
DavidHuber-NOAA approved these changes May 19, 2025
View reviewed changes

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@KateFriedman-NOAA KateFriedman-NOAA merged commit c9952dc into NOAA-EMC:develop May 19, 2025
5 checks passed
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request May 23, 2025
Merged
6 tasks
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the retrotest2develop branch June 26, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA left review comments

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@aerorahul aerorahul aerorahul left review comments

@CatherineThomas-NOAA CatherineThomas-NOAA CatherineThomas-NOAA left review comments

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA is a code owner

@WalterKolczynski-NOAA WalterKolczynski-NOAA Awaiting requested review from WalterKolczynski-NOAA

@RuiyuSun RuiyuSun Awaiting requested review from RuiyuSun

+1 more reviewer

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Creating a full resolution WCDA experiment